Repository navigation
DataGrid: Fix the column headers scroll position reset in RTL mode with native scrolling - #35503
Merged
Alyar666 merged 1 commit intoOct 6, 2026
Merged
Conversation
…th native scrolling
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused sentinel correction is consistent with existing synchronization logic and has appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes DataGrid column-header scroll restoration for negative RTL native-scroll positions.
Changes:
- Uses
undefinedas the uninitialized scroll-position sentinel. - Restores all defined positions, including negative RTL offsets.
- Adds Jest integration and TestCafe regression coverage for render, resize, and repaint.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/views/m_columns_view.ts |
Preserves negative header scroll offsets. |
packages/devextreme/js/__internal/grids/grid_core/views/__tests__/columns_view.scroll_position.integration.test.ts |
Tests RTL and LTR restoration behavior. |
e2e/testcafe-devextreme/tests/dataGrid/common/scrolling.ts |
Verifies RTL native scrolling after resize and repaint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bit-byte0
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.